jackye1995 commented on a change in pull request #4308: URL: https://github.com/apache/iceberg/pull/4308#discussion_r824211065
########## File path: core/src/main/java/org/apache/iceberg/expressions/ExpressionParser.java ########## @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.expressions; + +import com.fasterxml.jackson.core.JsonGenerator; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.ObjectMapper; +import java.io.IOException; +import java.io.StringWriter; +import java.io.UncheckedIOException; +import java.math.BigDecimal; +import java.nio.ByteBuffer; +import java.nio.charset.StandardCharsets; +import java.util.List; +import java.util.Locale; +import java.util.Set; +import java.util.UUID; +import org.apache.iceberg.exceptions.RuntimeIOException; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.types.Conversions; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.Types; +import org.apache.iceberg.util.JsonUtil; + +public class ExpressionParser { + private static final String TYPE = "type"; + private static final String VALUE = "value"; + private static final String OPERATION = "operation"; + private static final String LITERALS = "literals"; + private static final String TERM = "term"; + private static final String LEFT_OPERAND = "left-operand"; + private static final String RIGHT_OPERAND = "right-operand"; + private static final String OPERAND = "operand"; + private static final String AND = "and"; + private static final String OR = "or"; + private static final String NOT = "not"; + private static final String TRUE = "true"; + private static final String FALSE = "false"; + private static final String UNBOUNDED_PREDICATE = "unbounded-predicate"; + private static final String BOUNDED_LITERAL_PREDICATE = "bounded-literal-predicate"; + private static final String BOUNDED_SET_PREDICATE = "bounded-set-predicate"; + private static final String BOUNDED_UNARY_PREDICATE = "bounded-unary-predicate"; + private static final Set<String> PREDICATE_TYPES = Sets.newHashSet( + UNBOUNDED_PREDICATE, + BOUNDED_LITERAL_PREDICATE, + BOUNDED_SET_PREDICATE, + BOUNDED_UNARY_PREDICATE); + private static final String NAMED_REFERENCE = "named-reference"; + private static final String BOUND_REFERENCE = "bound-reference"; + + private static final Set<Expression.Operation> ONE_INPUTS = ImmutableSet.of( + Expression.Operation.IS_NULL, + Expression.Operation.NOT_NULL, + Expression.Operation.IS_NAN, + Expression.Operation.NOT_NAN); + + private ExpressionParser() { + } + + public static String toJson(Expression expression, boolean pretty) { + try { + StringWriter writer = new StringWriter(); + JsonGenerator generator = JsonUtil.factory().createGenerator(writer); + if (pretty) { + generator.useDefaultPrettyPrinter(); + } + toJson(expression, generator); + generator.flush(); + return writer.toString(); + + } catch (IOException e) { + throw new UncheckedIOException("Failed to write json", e); + } + } + + public static void toJson(Expression expression, JsonGenerator generator) throws IOException { + if (expression instanceof And) { + toJson((And) expression, generator); + } else if (expression instanceof Or) { + toJson((Or) expression, generator); + } else if (expression instanceof Not) { + toJson((Not) expression, generator); + } else if (expression instanceof True) { + toJson((True) expression, generator); + } else if (expression instanceof False) { + toJson((False) expression, generator); + } else if (expression instanceof Predicate) { + toJson((Predicate<?, ?>) expression, generator); + } else { + throw new IllegalArgumentException("Invalid Operation Type"); + } + } + + public static void toJson(And expression, JsonGenerator generator) throws IOException { + generator.writeStartObject(); + generator.writeStringField(TYPE, AND); Review comment: here can we reuse the word "operation"? Because phrases like "and" and "or" are operations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
