rdblue commented on a change in pull request #4270: URL: https://github.com/apache/iceberg/pull/4270#discussion_r824975890
########## File path: flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/assigner/GetSplitResult.java ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.flink.source.assigner; + +import javax.annotation.Nullable; +import org.apache.flink.annotation.Internal; +import org.apache.iceberg.flink.source.split.IcebergSourceSplit; + +@Internal +public class GetSplitResult { + + public enum Status { + + AVAILABLE, + + /** + * There are pending splits. But they can't be assigned + * due to constraints (like event time alignment) + */ + CONSTRAINED, + + /** + * Assigner doesn't have pending splits. + */ + UNAVAILABLE + } + + private final Status status; + @Nullable + private final IcebergSourceSplit split; + + public GetSplitResult(Status status) { + this(status, null); + } + + public GetSplitResult(Status status, @Nullable IcebergSourceSplit split) { Review comment: You may want to make this private and use a factory method like the other event types: ```java public static GetSplitResult forSplit(IcebergSourceSplit split) { return new GetSplitResult(AVAILABLE, split); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
