kbendick commented on a change in pull request #4315:
URL: https://github.com/apache/iceberg/pull/4315#discussion_r825147756
##########
File path:
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestFlinkTableSink.java
##########
@@ -96,14 +96,11 @@ public TestFlinkTableSink(String catalogName, Namespace
baseNamespace, FileForma
protected TableEnvironment getTableEnv() {
if (tEnv == null) {
synchronized (this) {
- EnvironmentSettings.Builder settingsBuilder = EnvironmentSettings
- .newInstance()
- .useBlinkPlanner();
+ EnvironmentSettings.Builder settingsBuilder =
EnvironmentSettings.newInstance();
if (isStreamingJob) {
settingsBuilder.inStreamingMode();
StreamExecutionEnvironment env = StreamExecutionEnvironment
.getExecutionEnvironment(MiniClusterResource.DISABLE_CLASSLOADER_CHECK_CONFIG);
- env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime);
Review comment:
Oh yeah that's also deprecated. That's the default value now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
