rdblue commented on a change in pull request #4311:
URL: https://github.com/apache/iceberg/pull/4311#discussion_r825520998
##########
File path:
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestFlinkTableSink.java
##########
@@ -253,6 +253,34 @@ public void testInsertIntoPartition() throws Exception {
}
}
+ @Test
+ public void testInsertWithUpsertAndScanFilterWithNonEqualityField() {
+ Assume.assumeTrue(format == FileFormat.PARQUET);
+ String tableName = "test_insert";
+
+ Map<String, String> tableProps = ImmutableMap.of(
+ "write.format.default", format.name(),
+ TableProperties.FORMAT_VERSION, "2",
+ TableProperties.UPSERT_ENABLED, "true"
+ );
+
+ sql("CREATE TABLE %s(id INT NOT NULL, dt DATE, PRIMARY KEY (id) NOT
ENFORCED) PARTITIONED BY (id) WITH %s",
+ tableName, toWithClause(tableProps));
+
+ // insert data set
+ sql("INSERT INTO %s VALUES " +
+ "(1, to_date('2021-01-01','yyyy-MM-dd'))", tableName);
Review comment:
Can you fix formatting? Continuation indents are 4 spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
