dramaticlly edited a comment on pull request #4262: URL: https://github.com/apache/iceberg/pull/4262#issuecomment-1067193198
@samredai @jun-he , I finally get some time to rebase the latest upstream, added more unit test coverage (from 71% to 97% so no longer need to make exception for the class any more). Also improved based on comments from @CircArgs to simplify the initialization code and moved module level attribute min/max for java primitives into corresponding IcebergTypes I think it shall be ready for review and appreciate your valuable feedbacks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
