jackye1995 commented on a change in pull request #2638:
URL: https://github.com/apache/iceberg/pull/2638#discussion_r826386745
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3InputFile.java
##########
@@ -20,12 +20,16 @@
package org.apache.iceberg.aws.s3;
import org.apache.iceberg.aws.AwsProperties;
+import org.apache.iceberg.encryption.NativeFileCryptoParameters;
+import org.apache.iceberg.encryption.NativelyEncryptedFile;
import org.apache.iceberg.io.InputFile;
import org.apache.iceberg.io.SeekableInputStream;
import org.apache.iceberg.metrics.MetricsContext;
import software.amazon.awssdk.services.s3.S3Client;
-public class S3InputFile extends BaseS3File implements InputFile {
+public class S3InputFile extends BaseS3File implements InputFile,
NativelyEncryptedFile {
+ private NativeFileCryptoParameters nativeDecryptionParameters;
Review comment:
can you make the the parameter name match the class name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
