kbendick commented on a change in pull request #4318: URL: https://github.com/apache/iceberg/pull/4318#discussion_r826548898
########## File path: python/src/iceberg/table/schema.py ########## @@ -0,0 +1,346 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import sys +from typing import Iterable, Tuple + +if sys.version_info >= (3, 8): # pragma: no cover + from typing import Protocol +else: # pragma: no cover + from typing_extensions import Protocol # type: ignore + +if sys.version_info >= (3, 8): # pragma: no cover + from functools import singledispatchmethod +else: # pragma: no cover + from singledispatch import singledispatchmethod # type: ignore + +from iceberg.types import IcebergType, ListType, MapType, NestedField, StructType + + +class SchemaVisitor(Protocol): + def visit(self, node) -> None: # pragma: no cover Review comment: Question: is this returning `None` and then using the `result` field instead because the returned dictionaries are somewhat different? In either case, would it make sense to add a doc string to this Protocol, indicating that the `result` is used? Not sure if a good way to phrase it but having `None` as the return type makes me feel like it’s going to mutate `node` or some internal state (which I don’t believe they do). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
