kbendick commented on a change in pull request #3249:
URL: https://github.com/apache/iceberg/pull/3249#discussion_r826568867
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java
##########
@@ -36,6 +36,7 @@
private final Dictionary dictionary;
private final NullabilityHolder nullabilityHolder;
private final Type icebergType;
+ private final Type originalIcebergType;
Review comment:
Not sure if this comment is up to date or not, and if you’re planning on
keeping both fields.
But would it make sense to use terms like iceberg type, logical type, and
physical type?
In your example of the parquet int backed decimal, I would call the field
that is integer as `physicalType` and the decimal field as `logicalType`.
I feel these terms are more self documenting and wouldn’t require the
comment here. How you choose to name them exactly is up to you, but the terms
physical / logical are much more self documenting in my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
