ggershinsky commented on a change in pull request #2638: URL: https://github.com/apache/iceberg/pull/2638#discussion_r826773600
########## File path: core/src/main/java/org/apache/iceberg/encryption/NativeFileCryptoParameters.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.encryption; + +import java.nio.ByteBuffer; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * Barebone encryption parameters, one object per content file. + * Carries the file encryption key (later, will be extended with column keys and AAD prefix). + * Applicable only to formats with native encryption support (Parquet and ORC). + */ +public class NativeFileCryptoParameters { Review comment: by "carries the file encryption key", we mean in-memory-only delivery of the crypto parameters from the Iceberg key management module, to the format-native writer/reader objects. The key management is distributed, but it is handled by the EncryptionManager interface that already extends `Serialize`; therefore, we have a local representation, an EncryptionManager object co-located with the native format objects in the same process memory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
