[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #4296: CheckstyleV2:Add checkstyle rule to prevent using raw ConcurrentHashMap, LinkedHashSet

Tue, 15 Mar 2022 09:55:06 -0700 


RussellSpitzer commented on a change in pull request #4296:
URL: https://github.com/apache/iceberg/pull/4296#discussion_r827206887



##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -56,6 +56,11 @@
         <property name="message"
                   value="Prefer using Maps.newHashMap instead."/>
     </module>
+    <module name="RegexpSingleline">
+        <property name="format" value="new ConcurrentHashMap&lt;&gt;\(.*\)"/>
+        <property name="message"

Review comment:
       This looks good to me but does it need to be two lines? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to