stevenzwu commented on a change in pull request #4341:
URL: https://github.com/apache/iceberg/pull/4341#discussion_r828187463
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java
##########
@@ -200,8 +200,9 @@ ScanContext copyWithAppendsBetween(long newStartSnapshotId,
long newEndSnapshotI
.project(schema)
.filters(filters)
.limit(limit)
- .exposeLocality(exposeLocality)
.includeColumnStats(includeColumnStats)
+ .exposeLocality(exposeLocality)
Review comment:
yes. this is to be consistent with the ordering of how variables are
defined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]