singhpk234 opened a new pull request #4347: URL: https://github.com/apache/iceberg/pull/4347
presently TestS3FileIOIntegration fails with NPE because of s3FileIo.Initialize not being called. This happens because writeTags is never intialized if we don't call it's initialize and it always remains null so when we check if it's empty or not while initializing upload / mutlipart upload it faces NPE. https://github.com/apache/iceberg/blob/c1adf2034280884d05afad4e67f09f2872c47d78/aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java#L70 https://github.com/apache/iceberg/blob/c1adf2034280884d05afad4e67f09f2872c47d78/aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java#L263 Ideally we should initialize while declaration like we do metrics to avoid this scenario. Post this fix test passes ----- cc: @jackye1995 @rajarshisarkar @arminnajafi @amogh-jahagirdar @xiaoxuandev @yyanyy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
