jackye1995 commented on a change in pull request #4342:
URL: https://github.com/apache/iceberg/pull/4342#discussion_r828372740
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -111,11 +116,15 @@ public OutputFile newOutputFile(String path) {
@Override
public void deleteFile(String path) {
- S3URI location = new S3URI(path);
Review comment:
to minimize diff, we can do the reverse logic instead to avoid a lot of
indentation change, e.g.
```
if (!deleteTags.isEmpty()) {
doSoftDelete(path);
return;
}
// original logic
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
