Fokko commented on a change in pull request #4262:
URL: https://github.com/apache/iceberg/pull/4262#discussion_r828812459
##########
File path: python/tox.ini
##########
@@ -25,6 +25,10 @@ deps =
mock
pytest
pyarrow
+ pytz
Review comment:
Should we define those here as well? I would argue that we already set
these in `setup.cfg`, and if we start pinning them to certain versions, it is
better to set this in one place.
##########
File path: python/tox.ini
##########
@@ -65,6 +69,9 @@ commands =
[testenv:type-check]
deps =
mypy
+ types-pytz
Review comment:
You could also install these types implicitly:
https://mypy.readthedocs.io/en/stable/command_line.html#miscellaneous
This has to be combined with the non-interactive flag:
https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-non-interactive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
