singhpk234 commented on a change in pull request #4355:
URL: https://github.com/apache/iceberg/pull/4355#discussion_r829412871
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/GlueTestBase.java
##########
@@ -69,8 +69,8 @@
// table location properties
static final Map<String, String> tableLocationProperties = ImmutableMap.of(
- TableProperties.WRITE_DATA_LOCATION, "s3://" + testBucketName +
"/writeDataLoc",
TableProperties.WRITE_METADATA_LOCATION, "s3://" + testBucketName +
"/writeMetaDataLoc",
+ TableProperties.WRITE_DATA_LOCATION, "s3://" + testBucketName +
"/writeDataLoc",
Review comment:
if we were to make changes I would recommend changing this :
https://github.com/apache/iceberg/blob/5b9cd7a68478f9fddd569765bfaec285d92f5907/aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java#L77
sort both the collections as it may happen post picking these changes it
failing in my machine
```java
Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values().stream().sorted().collect(
Collectors.toList()),
response.table().storageDescriptor().additionalLocations().stream().sorted().collect(Collectors.toList()));
```
as I can confirm that for the present master branch these tests passes on my
machine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
