shardulm94 commented on a change in pull request #4242:
URL: https://github.com/apache/iceberg/pull/4242#discussion_r829344056
##########
File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java
##########
@@ -154,6 +154,27 @@ public static boolean isOptionSchema(Schema schema) {
return false;
}
+ /**
+ * This method decides whether a schema is of type union and is complex
union and is optional
+ *
+ * Complex union: the number of options in union not equals to 2
+ * Optional: null is present in union
+ *
+ * @param schema input schema
+ * @return true if schema is complex union and it is optional
+ */
+ public static boolean isOptionalComplexUnion(Schema schema) {
+ if (schema.getType() == UNION && schema.getTypes().size() != 2) {
Review comment:
What happens if it receives a schema like `["null"]`. This is regarded
as an optional complex union by this function. Is this expected? Should we
instead check for `schema.getTypes().size() > 2`. What is the impact of this
return true on the readers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
