jackye1995 commented on a change in pull request #4355:
URL: https://github.com/apache/iceberg/pull/4355#discussion_r829492753
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,8 +75,9 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
- Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
- response.table().storageDescriptor().additionalLocations());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values().stream().sorted().collect(
Review comment:
can we break newline at a more intuitive place?
```
Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values().stream().sorted().collect(Collectors.toList()),
response.table().storageDescriptor().additionalLocations().stream().sorted().collect(Collectors.toList()));
```
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,8 +75,9 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
- Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
- response.table().storageDescriptor().additionalLocations());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values().stream().sorted().collect(
Review comment:
actually, it looks like we should compare it as Set instead of List
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,8 +75,9 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
- Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
- response.table().storageDescriptor().additionalLocations());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values().stream().sorted().collect(
Review comment:
oh yes good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
