xiaoxuandev commented on a change in pull request #4355:
URL: https://github.com/apache/iceberg/pull/4355#discussion_r829443631
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/GlueTestBase.java
##########
@@ -69,8 +69,8 @@
// table location properties
static final Map<String, String> tableLocationProperties = ImmutableMap.of(
- TableProperties.WRITE_DATA_LOCATION, "s3://" + testBucketName +
"/writeDataLoc",
TableProperties.WRITE_METADATA_LOCATION, "s3://" + testBucketName +
"/writeMetaDataLoc",
+ TableProperties.WRITE_DATA_LOCATION, "s3://" + testBucketName +
"/writeDataLoc",
Review comment:
Thanks for the suggestion. That makes sense as we are comparing a map's
valueSet and a list. I have updated the change. Please have another look.
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
##########
@@ -74,8 +75,9 @@ public void testCreateTable() {
Assert.assertTrue(response.table().parameters().containsKey(BaseMetastoreTableOperations.METADATA_LOCATION_PROP));
Assert.assertEquals(schema.columns().size(),
response.table().storageDescriptor().columns().size());
Assert.assertEquals(partitionSpec.fields().size(),
response.table().partitionKeys().size());
- Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values(),
- response.table().storageDescriptor().additionalLocations());
+ Assert.assertEquals("additionalLocations should match",
tableLocationProperties.values().stream().sorted().collect(
Review comment:
fixed line break. list also handles special case like duplicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
