coolderli commented on a change in pull request #4005:
URL: https://github.com/apache/iceberg/pull/4005#discussion_r829915498
##########
File path: core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java
##########
@@ -516,6 +522,101 @@ public void testPartitionColumnNamedPartition() throws
Exception {
validateIncludesPartitionScan(tasksAndEq, 0);
}
+ @Test
+ public void testPartitionsTableScanWithDeleteFilesInFilter() throws
IOException {
+ Assume.assumeTrue(formatVersion == 2);
+ Configuration conf = new Configuration();
+ HadoopTables tables = new HadoopTables(conf);
Review comment:
I have tried to use `new PartitionTable(table.ops(), table)`, but it
return a NPE on `ops.current().metadataFileLocation()`.
https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/PartitionsTable.java#L84
##########
File path: core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java
##########
@@ -516,6 +522,101 @@ public void testPartitionColumnNamedPartition() throws
Exception {
validateIncludesPartitionScan(tasksAndEq, 0);
}
+ @Test
+ public void testPartitionsTableScanWithDeleteFilesInFilter() throws
IOException {
+ Assume.assumeTrue(formatVersion == 2);
+ Configuration conf = new Configuration();
+ HadoopTables tables = new HadoopTables(conf);
+ File tableLocation = new File(temp.newFolder(), "table");
+ Table table = tables.create(
Review comment:
I use HadoopTable to load the PartitionTable, so I can read the records.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
