rdblue commented on a change in pull request #4334:
URL: https://github.com/apache/iceberg/pull/4334#discussion_r830681624
##########
File path: aws/src/test/java/org/apache/iceberg/aws/s3/TestS3URI.java
##########
@@ -90,4 +92,17 @@ public void testValidSchemes() {
assertEquals("path/to/file", uri.key());
}
}
+
+ @Test
+ public void testS3URIWithBucketToAccessPointMapping() {
+ String p1 = "s3://bucket/path/to/file?query=foo#bar";
+ Map<String, String> bucketToAccessPointMapping = ImmutableMap.of(
+ "bucket", "access-point"
+ );
+ S3URI uri1 = new S3URI(p1, bucketToAccessPointMapping);
+
+ assertEquals("access-point", uri1.bucket());
Review comment:
Should there be any validation that the access point is in a valid
format? Or is that handled by the SDK and we don't want to duplicate logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
