amogh-jahagirdar commented on pull request #4071: URL: https://github.com/apache/iceberg/pull/4071#issuecomment-1073400121
@rdblue I was iterating some more on this PR today, thank you so much for taking a quick look! I think some of your comments were on my initial changes, which I resolved in later iterations. Let me know your thoughts on the latest version. @jackye1995 as well. I think from this point, I will be adding tests to validate the expected behavior which can surface any other bugs/cases in the implementation which I haven't caught yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
