kbendick commented on a change in pull request #4367:
URL: https://github.com/apache/iceberg/pull/4367#discussion_r830732103
##########
File path: open-api/rest-catalog-open-api.yaml
##########
@@ -1537,9 +1622,39 @@ components:
EmptyResponse:
$ref: '#/components/examples/ListNamespacesEmptyExample'
+ AuthenticationTimeoutResponse:
+ description:
+ Credentials have timed out. If possible, the client should refresh
credentials and retry.
+ content:
+ application/json:
+ schema:
+ $ref: '#/components/schemas/ErrorModel'
+ example: {
+ "error": {
+ "message": "Credentials have timed out",
+ "type": "AuthenticationTimeoutException",
+ "code": 419
+ }
+ }
+
+ ServiceUnavailableResponse:
+ description:
+ The service is not ready to handle the request. The client should wait
and retry.
Review comment:
According to the mozilla documentation, if possible, a `Retry-After`
header should be used if possible to indicate when the client should retry
after: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/503
Presumably the HTTP client handles all of this, and it doesn't need to be in
the spec, but wanted to call attention to it. Possibly something to add to the
description as a note, even if just in a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]