aokolnychyi commented on a change in pull request #4370:
URL: https://github.com/apache/iceberg/pull/4370#discussion_r831619096
##########
File path: core/src/main/java/org/apache/iceberg/ManifestFilterManager.java
##########
@@ -360,23 +360,23 @@ private boolean
manifestHasDeletedFiles(PartitionAndMetricsEvaluator evaluator,
dropPartitions.contains(file.specId(), file.partition()) ||
(isDelete && entry.sequenceNumber() > 0 && entry.sequenceNumber() <
minSequenceNumber);
- boolean nonMatchingDeleteFile = !file.content().equals(FileContent.DATA)
&& !evaluator.rowsMustMatch(file);
Review comment:
We should avoid extra calls to `evaluator` if possible. Also, there was
`isDelete` var already defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
