RussellSpitzer commented on a change in pull request #4369:
URL: https://github.com/apache/iceberg/pull/4369#discussion_r832557503



##########
File path: docs/spark/spark-configuration.md
##########
@@ -185,4 +185,5 @@ df.write
 | snapshot-property._custom-key_    | null            | Adds an entry with 
custom-key and corresponding value in the snapshot summary  |
 | fanout-enabled       | false        | Overrides this table's 
write.spark.fanout.enabled  |
 | check-ordering       | true        | Checks if input schema and table schema 
are same  |
-
+| isolation-level | null | Desired isolation level for Dataframe overwrite 
operations.  Null => no checks, `serializable` => check for concurrent inserts 
or deletes in destination partitions, `snapshot` => checks for concurrent 
deletes in destination partitions. |
+| validate-from-snapshot-id | null | If isolation level is set, identifies 
base snapshot from which to check concurrent conflicts. If null, check from the 
first un-expired snapshot.  Obtain via 
`Spark3Util.loadIcebergTable().currentSnapshot().snapshotId()` |

Review comment:
       I've definitely been recommending that folks use this method to get 
table references from Spark, do you think we should be making the function 
private? For example when using the programmatic Action API, 
Spark3Util.loadIcebergTable is much less error prone than creating the Catalog 
class (like HiveCatalog) directly and loading the table that way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to