hililiwei commented on a change in pull request #3784: URL: https://github.com/apache/iceberg/pull/3784#discussion_r832921020
########## File path: orc/src/main/java/org/apache/iceberg/orc/EstimateOrcAveWidthVisitor.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.orc; + +import java.util.List; +import java.util.Optional; +import org.apache.orc.TypeDescription; + +public class EstimateOrcAveWidthVisitor extends OrcSchemaVisitor<Integer> { + + @Override + public Integer record(TypeDescription record, List<String> names, List<Integer> fields) { + return fields.stream().reduce(Integer::sum).orElse(0); + } + + @Override + public Integer list(TypeDescription array, Integer elementResult) { + return elementResult; + } + + @Override + public Integer map(TypeDescription map, Integer keyWidth, Integer valueWidth) { + return keyWidth + valueWidth; + } + + @Override + public Integer primitive(TypeDescription primitive) { + Optional<Integer> icebergIdOpt = ORCSchemaUtil.icebergID(primitive); + + if (!icebergIdOpt.isPresent()) { + return 0; + } + + switch (primitive.getCategory()) { Review comment: The corresponding relationship is as follows: ``` Boolean -> LongColumnVector Byte -> LongColumnVector Short -> LongColumnVector INT -> LongColumnVector LONG -> LongColumnVector FLOAT -> DoubleColumnVector DOUBLE -> DoubleColumnVector DATE -> LongColumnVector TIMESTAMP -> TimestampColumnVector BINARY -> BytesColumnVector STRING -> BytesColumnVector DECIMAL -> Decimal18Writer or Decimal38Writer ``` The byte estimation corresponds: ``` LongColumnVector -> 8 byte DoubleColumnVector -> 8 byte TimestampColumnVector -> 12 byte Decimal18Writer/Decimal38Writer -> (precision + 4) / 2 byte BytesColumnVector -> 128 byte ``` How about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
