kbendick commented on a change in pull request #3784:
URL: https://github.com/apache/iceberg/pull/3784#discussion_r833647509
##########
File path: build.gradle
##########
@@ -449,6 +449,7 @@ project(':iceberg-orc') {
dependencies {
implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
api project(':iceberg-api')
+ implementation project(':iceberg-common')
Review comment:
Are we sure we need to add `iceberg-common`? Looking at the definition
of `iceberg-common`, it appears to be the same as line 450's
`iceberg-bundled-guava`, using shadow configuration.
https://github.com/apache/iceberg/blob/718ff6ae514d7a16077c21e5281e765ba5fa120b/build.gradle#L199-L203
I do see it duplicated multiple times though in other places.
EDIT: Nevermind. I see that it does seem to need to be duplicated because of
the relocation it seems. I think declaring `iceberg-common` forces it to build
the shaded / relocaqted bundled-guava artifact first. Sorry for the noise! I'm
still more used to bazel and other somewhat less common tools. 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
