szehon-ho commented on a change in pull request #4382:
URL: https://github.com/apache/iceberg/pull/4382#discussion_r833832870
##########
File path: core/src/main/java/org/apache/iceberg/BaseFilesTable.java
##########
@@ -88,6 +93,18 @@ public TableScan appendsAfter(long fromSnapshotId) {
String.format("Cannot incrementally scan table of type %s",
type.name()));
}
+ @Override
+ public CloseableIterable<FileScanTask> planFiles() {
+ if (type.equals(MetadataTableType.ALL_DATA_FILES)) {
Review comment:
I had to move this code from BaseAllMetadataTableScan.
I didn't realize that there was an alternate base class for "All*" metadata
tables with special handling (it seems for WAP case). As there's no multiple
inheritance for Java, I can't inherit from both BaseFileTable and
BaseAllMetadataTable scans, so I decided to copy the logic.
An alternative is to use composition, let me know if that's a better way, as
I thought it's a bit overkill for a few lines. As a consequence now though,
the BaseAllMetadataTableScan supports only 'all_entries' table, and now we have
to change two places if any 'all*' handling changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
