openinx commented on a change in pull request #4264:
URL: https://github.com/apache/iceberg/pull/4264#discussion_r833889823
##########
File path: core/src/main/java/org/apache/iceberg/io/FileWriter.java
##########
@@ -54,6 +54,20 @@ default void write(Iterable<T> rows) {
*/
void write(T row);
+ /**
+ * Returns the file path that are currently opened.
+ *
+ * @return the current file path.
+ */
+ CharSequence location();
+
+ /**
+ * Returns the row offset that are currently writing, starting from 0.
Review comment:
As we've discussed in
https://github.com/apache/iceberg/pull/4264/files#r819238913, I agree
`recordCount` is a good & consistent name.
##########
File path: core/src/main/java/org/apache/iceberg/io/FileWriter.java
##########
@@ -54,6 +54,20 @@ default void write(Iterable<T> rows) {
*/
void write(T row);
+ /**
+ * Returns the file path that are currently opened.
+ *
+ * @return the current file path.
+ */
+ CharSequence location();
+
+ /**
+ * Returns the row offset that are currently writing, starting from 0.
Review comment:
As we've discussed in
https://github.com/apache/iceberg/pull/4264/files#r819238913, I agree
`recordCount` is a good & consistent name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
