kbendick edited a comment on issue #4289: URL: https://github.com/apache/iceberg/issues/4289#issuecomment-1078438167
I matched the admittedly wild regex used there against this test query statement. https://regex101.com/r/9cs1yV/1 Fortunately, this function doesn't modify the query at all, just how the query is determined to be an Iceberg-specifc DDL query or not. We still delegate to the _existing_ antlr parser for processing the query, and only strip comments out when we're checking if this is Iceberg specific DDL. Hence there's no concerns about accidentally dropping SQL hints, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
