dramaticlly commented on pull request #4262: URL: https://github.com/apache/iceberg/pull/4262#issuecomment-1080037341
Thank you @samredai for sending me the patch for addressing most of the comments from @rdblue , I was on personal leave last week so did not have the chance to update in time. I believe Sam helped with parametrizing the Literal class with python primitive type, added type hint for both parameters and return type, introduced ABC abstract method, removed several intermediate abstraction together with better handle on float and datetime literal. `fastavro` is no longer part of the test dependency and rebased from latest upstream to resolve conflict :) CC @jun-he -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
