RussellSpitzer commented on a change in pull request #4377:
URL: https://github.com/apache/iceberg/pull/4377#discussion_r836520898
##########
File path: api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java
##########
@@ -88,6 +90,19 @@
String USE_STARTING_SEQUENCE_NUMBER = "use-starting-sequence-number";
boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = true;
+ /**
+ * Forces the compaction order based on the value.
+ * <p>
+ * If rewrite.job-order=bytes, then compact based on ascending order of
partition size in bytes.
Review comment:
When I commented on the size before I wasn't sure which made more sense,
do these sort orders make sense for your use case? I was generally thinking
about performance and how usually we want to leave possible stragglers till the
end but I could be wrong. I'm interested to hear your reasoning and why we
should go one way or the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
