singhpk234 commented on a change in pull request #4407:
URL: https://github.com/apache/iceberg/pull/4407#discussion_r836591029
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java
##########
@@ -54,8 +54,8 @@ public static boolean hive3PresentOnClasspath() {
}
/**
- * Invokes alterTable via metaStoreClient without triggering recursive
listing.
- * ref: https://github.com/apache/iceberg/pull/734#issuecomment-574062407
+ * If possible, call the alter_table method via metaStoreClient with an
environment context that turns off stats
Review comment:
> Nits: Why "if possible"? The final comma is also not needed so
It's due to this signature which is added as final fallback, as everytime it
might not be possible to pass envContext as it might not be supported.
```java
.impl(IMetaStoreClient.class, "alter_table",
String.class, String.class, Table.class)
```
> "The final comma is also not needed so"
makes sense.
"If possible, calls alter_table method using the metastore client with an
environmental context that turns off stats update to avoid recursive file
listing"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
