jackye1995 commented on a change in pull request #4411:
URL: https://github.com/apache/iceberg/pull/4411#discussion_r836697861
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
##########
@@ -258,15 +264,9 @@ private WriteBuilder
createContextFunc(Function<Map<String, String>, Context> ne
if (createWriterFunc != null) {
Preconditions.checkArgument(writeSupport == null,
"Cannot write with both write support and Parquet value writer");
- Configuration conf;
- if (file instanceof HadoopOutputFile) {
- conf = ((HadoopOutputFile) file).getConf();
- } else {
- conf = new Configuration();
- }
for (Map.Entry<String, String> entry : config.entrySet()) {
- conf.set(entry.getKey(), entry.getValue());
+ this.conf.set(entry.getKey(), entry.getValue());
Review comment:
this looks like unnecessary change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
