rdblue commented on a change in pull request #4262:
URL: https://github.com/apache/iceberg/pull/4262#discussion_r836941561



##########
File path: python/setup.cfg
##########
@@ -42,6 +42,10 @@ package_dir =
     = src
 packages = find:
 python_requires = >=3.7
+install_requires =
+    pytz
+    python-dateutil

Review comment:
       I don't think that either one of these libraries is needed. I just did a 
thorough review of what `datetime` supports and I was able to get everything 
working.
   
   The main reason why we don't need these is that we are _very_ strict about 
date/time conversions and only support a limited set of strings in ISO 8601 
formats, and support only offsets rather than zone strings.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to