openinx commented on a change in pull request #3998:
URL: https://github.com/apache/iceberg/pull/3998#discussion_r837007918
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -339,15 +348,29 @@ public Builder setSnapshotProperty(String property,
String value) {
*/
@Deprecated
public DataStreamSink<RowData> build() {
- return chainIcebergOperators();
+ return append();
}
/**
* Append the iceberg sink operators to write records to iceberg table.
*
* @return {@link DataStreamSink} for sink.
*/
- public DataStreamSink<Void> append() {
+ @SuppressWarnings("rawtypes")
Review comment:
Why change this public method's return data type ? Be careful it's a
incompatibility changes. In the first version, w e introduced the
`FlinkSink#build` method with an incorrect return data type, and then we marked
it as deprecated in this [PR](https://github.com/apache/iceberg/pull/3061)
If any changes are planning to make in this PR, then we will need to follow
the same approach. In my thought, I don't think we need to change this, the
current `DataStreamSink<Void>` is the correct return type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
