hililiwei commented on pull request #3998: URL: https://github.com/apache/iceberg/pull/3998#issuecomment-1081530559
> I'm okay to add customized properties to override the table properties for a given write flink job, BUT I'm very concern that the current PR did not make the merged properties go though the whole write path because I still see lots of places in write path just use the table properties to parse the configured keys ( That means the customized properties will be useless , although we've customized it). > > For example, The [RowDataTaskWriterFactory](https://github.com/apache/iceberg/blob/340a0c5f30a7fb1e33dde4c1f082fd4cb9f7472f/flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/RowDataTaskWriterFactory.java#L88) will use the serialized table to initialize the `OutputFileFactory` which will use the table properties .... Thanks for the correction. Let me go through as many end to end as I can and see what I'm missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
