RussellSpitzer commented on a change in pull request #4376:
URL: https://github.com/apache/iceberg/pull/4376#discussion_r837746097
##########
File path:
hive3/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimestampObjectInspectorHive3.java
##########
@@ -50,6 +50,7 @@ public LocalDateTime convert(Object o) {
}
@Override
+ @SuppressWarnings("JavaLocalDateTimeGetNano")
Review comment:
Why is this ok to surpress, it does look like we are doing this
incorrectly here, shouldn't this be Timestamp.valueOf(LocalDateTime time)?
I would separate this out into another PR since we could be doing a semantic
change here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
