felixYyu commented on a change in pull request #4376:
URL: https://github.com/apache/iceberg/pull/4376#discussion_r838067187
##########
File path:
hive3/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimestampObjectInspectorHive3.java
##########
@@ -50,6 +50,7 @@ public LocalDateTime convert(Object o) {
}
@Override
+ @SuppressWarnings("JavaLocalDateTimeGetNano")
Review comment:
I change to `return o == null ? null : Timestamp.valueOf((LocalDateTime)
o);` ,but the check were not successful
```
/home/runner/work/iceberg/iceberg/hive3/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimestampObjectInspectorHive3.java:54:
error: incompatible types: java.time.LocalDateTime cannot be converted to
java.lang.String
return o == null ? null : Timestamp.valueOf((LocalDateTime) o);
```
so revert this, but why
IcebergTimestampObjectInspector.getPrimitiveJavaObject is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
