samredai commented on pull request #4318:
URL: https://github.com/apache/iceberg/pull/4318#issuecomment-1082621634


   Also, here's a comparison to `TypeUtil.indexById` in Java:
   ### Java
   ```java
   import org.apache.iceberg.Schema;
   import org.apache.iceberg.types.Types;
   import org.apache.iceberg.types.TypeUtil;
   
   Schema schema = new Schema(
         Types.NestedField.required(1, "foo", Types.StringType.get()),
         Types.NestedField.optional(2, "bar", Types.IntegerType.get()),
         Types.NestedField.required(3, "baz", Types.BooleanType.get()),
         Types.NestedField.required(4, "qux", Types.ListType.ofOptional(5, 
Types.StringType.get())),
         Types.NestedField.required(6, "quux", Types.MapType.ofOptional(7, 8, 
Types.StringType.get(), Types.MapType.ofOptional(9, 10, Types.StringType.get(), 
Types.IntegerType.get())))
   );
   Map<Integer, Types.NestedField> index = 
TypeUtil.indexById(schema.asStruct());
   System.out.println(index);
   ```
   output:
   ```
   {1=1: foo: required string, 2=2: bar: optional int, 3=3: baz: required 
boolean, 4=4: qux: required list<string>, 5=5: element: optional string, 6=6: 
quux: required map<string, map<string, int>>, 7=7: key: required string, 8=8: 
value: optional map<string, int>, 9=9: key: required string, 10=10: value: 
optional int}
   ```
   
   ### Python
   ```py
   from iceberg.types import (
       BooleanType,
       IntegerType,
       ListType,
       MapType,
       NestedField,
       StringType,
       StructType,
   )
   from iceberg.table.schema import Schema, index_by_id
   
   schema = Schema(
       NestedField(field_id=1, name="foo", field_type=StringType(), 
is_optional=False),
       NestedField(field_id=2, name="bar", field_type=IntegerType(), 
is_optional=True),
       NestedField(field_id=3, name="baz", field_type=BooleanType(), 
is_optional=False),
       NestedField(field_id=4, name="qux", field_type=ListType(element_id=5, 
element_type=StringType(), element_is_optional=True), is_optional=True),
       NestedField(field_id=6, name="quux", field_type=MapType(key_id=7, 
key_type=StringType(), value_id=8, value_type=MapType(key_id=9, 
key_type=StringType(), value_id=10, value_type=IntegerType(), 
value_is_optional=True), value_is_optional=True), is_optional=True)
   )
       
   index = index_by_id(schema)
   print(index)
   ```
   output:
   ```
   {
    1: NestedField(field_id=1, name='foo', field_type=StringType(), 
is_optional=False),
    2: NestedField(field_id=2, name='bar', field_type=IntegerType(), 
is_optional=True),
    3: NestedField(field_id=3, name='baz', field_type=BooleanType(), 
is_optional=False),
    4: NestedField(field_id=4, name='qux', field_type=ListType(element_id=5, 
element_type=StringType(), element_is_optional=True), is_optional=True),
    5: NestedField(field_id=5, name='element', field_type=StringType(), 
is_optional=True),
    6: NestedField(field_id=6, name='quux', field_type=MapType(key_id=7, 
key_type=StringType(), value_id=8, value_type=MapType(key_id=9, 
key_type=StringType(), value_id=10, value_type=IntegerType(), 
value_is_optional=True), value_is_optional=True), is_optional=True),
    7: NestedField(field_id=7, name='key', field_type=StringType(), 
is_optional=False),
    8: NestedField(field_id=8, name='value', field_type=MapType(key_id=9, 
key_type=StringType(), value_id=10, value_type=IntegerType(), 
value_is_optional=True), is_optional=True),
    9: NestedField(field_id=9, name='key', field_type=StringType(), 
is_optional=False),
    10: NestedField(field_id=10, name='value', field_type=IntegerType(), 
is_optional=True),
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to