openinx commented on a change in pull request #3991:
URL: https://github.com/apache/iceberg/pull/3991#discussion_r839156022
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/RowDataFileScanTaskReader.java
##########
@@ -55,11 +56,18 @@
private final Schema projectedSchema;
private final String nameMapping;
private final boolean caseSensitive;
+ private int[][] projectedFields;
Review comment:
We have already had a `projectedSchema`, why do we still need a
`projectedFields` here ? Shouldn't we just convert the `projectedFields` into
a `projectedSchema`, and then use the projected schema to go though the whole
read path ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
