samredai edited a comment on pull request #4436:
URL: https://github.com/apache/iceberg/pull/4436#issuecomment-1084497768
LGTM!
The lint failure is because mypy is confused by the `isinstance(value,
type)` in the constructor for `Literal`. Once it sees an isinstance check it
uses that to infer the expected type and for `type` it infers a very general
`object`. I think the best thing to do is to add a mypy ignore comment to the
value property method for `Literal`:
```py
@property
def value(self) -> T:
return self._value # type: ignore
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
