rdblue commented on a change in pull request #4448:
URL: https://github.com/apache/iceberg/pull/4448#discussion_r840004246
##########
File path: core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java
##########
@@ -113,7 +114,14 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
@Override
public void renameTable(TableIdentifier from, TableIdentifier to) {
+ RenameTableRequest request = RenameTableRequest.builder()
+ .withSource(from)
+ .withDestination(to)
+ .build();
+ // for now, ignore the response because there is no way to return it.
+ // also, the spec does not define a response beyond simply `ok`.
+ client.post("v1/tables/rename", request, null,
ErrorHandlers.tableErrorHandler());
Review comment:
If not, then maybe we should move it to a 204 response code that doesn't
have a result body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
