ajantha-bhat commented on a change in pull request #4464:
URL: https://github.com/apache/iceberg/pull/4464#discussion_r840475760
##########
File path: core/src/main/java/org/apache/iceberg/BaseTransaction.java
##########
@@ -368,14 +368,7 @@ private void commitSimpleTransaction() {
2.0 /* exponential */)
.onlyRetryOn(CommitFailedException.class)
.run(underlyingOps -> {
- if (base != underlyingOps.refresh()) {
- this.base = underlyingOps.current(); // just refreshed
- this.current = base;
- for (PendingUpdate update : updates) {
Review comment:
Initially thought of moving the update outside the if check, by direct
write test case (`testTransactionRewriteManifestsAppendedDirectly`) will fail
in that case.
Hence, falling back to the base metadata when the commit is failed. So, that
updates will be added again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
