jackye1995 commented on a change in pull request #4423:
URL: https://github.com/apache/iceberg/pull/4423#discussion_r840938768
##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java
##########
@@ -264,15 +265,25 @@ private boolean isGlueIcebergTable(Table table) {
@Override
public boolean dropTable(TableIdentifier identifier, boolean purge) {
+ TableOperations ops = newTableOps(identifier);
+ TableMetadata lastMetadata;
+ try {
+ lastMetadata = ops.current();
+ } catch (NoSuchKeyException ex) {
+ // S3 files already deleted, can not get S3 object through metadata
location
+ lastMetadata = null;
+ }
try {
- TableOperations ops = newTableOps(identifier);
- TableMetadata lastMetadata = ops.current();
glue.deleteTable(DeleteTableRequest.builder()
.catalogId(awsProperties.glueCatalogId())
.databaseName(IcebergToGlueConverter.getDatabaseName(identifier))
.name(identifier.name())
.build());
LOG.info("Successfully dropped table {} from Glue", identifier);
+ if (purge && awsProperties.glueLakeFormationEnabled() && lastMetadata !=
null) {
Review comment:
We can directly do the check upfront right? If `purge &&
awsProperties.glueLakeFormationEnabled()` we should directly throw error
without loading last metadata.
##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java
##########
@@ -264,15 +265,25 @@ private boolean isGlueIcebergTable(Table table) {
@Override
public boolean dropTable(TableIdentifier identifier, boolean purge) {
+ TableOperations ops = newTableOps(identifier);
+ TableMetadata lastMetadata;
+ try {
+ lastMetadata = ops.current();
+ } catch (NoSuchKeyException ex) {
+ // S3 files already deleted, can not get S3 object through metadata
location
+ lastMetadata = null;
+ }
try {
- TableOperations ops = newTableOps(identifier);
- TableMetadata lastMetadata = ops.current();
glue.deleteTable(DeleteTableRequest.builder()
.catalogId(awsProperties.glueCatalogId())
.databaseName(IcebergToGlueConverter.getDatabaseName(identifier))
.name(identifier.name())
.build());
LOG.info("Successfully dropped table {} from Glue", identifier);
+ if (purge && awsProperties.glueLakeFormationEnabled() && lastMetadata !=
null) {
+ throw new RuntimeException("Can not delete table S3 files, should call
deleteTable first " +
Review comment:
can use ValidationException.check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
