rdblue commented on a change in pull request #4461:
URL: https://github.com/apache/iceberg/pull/4461#discussion_r840968211
##########
File path: aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSFileIO.java
##########
@@ -89,7 +89,11 @@ public void deleteFile(String path) {
private OSS client() {
if (client == null) {
- client = oss.get();
+ synchronized (this) {
+ if (client == null) {
+ client = oss.get();
+ }
+ }
Review comment:
In the other PR, we were wondering whether we should just initialize the
client eagerly in `initialize` What do you think about that vs. lazy
initialization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
