samredai commented on a change in pull request #4468:
URL: https://github.com/apache/iceberg/pull/4468#discussion_r841256538
##########
File path: python/tests/expressions/test_operations.py
##########
@@ -17,26 +17,26 @@
import pytest
-from iceberg import expressions
+from iceberg.expressions import operations
Review comment:
+1 that operations should go into base.py but would it be helpful for
the tests to use the full imports? In other words `from iceberg.expressions
import base`. It makes it a bit easier to jump from looking at a test to the
relevant source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
