liuml07 commented on PR #4478:
URL: https://github.com/apache/iceberg/pull/4478#issuecomment-1086960356

   Thank you both for the feedback, really appreciate that!
   
   Originally I was following the pattern in #3912. I think again and it makes 
more sense to add identifier fields to DDL instead of the table properties. 
Meanwhile, if users need to create table with `TBLPROPERTIES 
('identifier-fields'='id')` while updating with  `ALTER TABLE SET|DROP 
IDENTIFIER FIELDS`, it could be confusing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to