kbendick commented on code in PR #4495: URL: https://github.com/apache/iceberg/pull/4495#discussion_r842270369
########## core/src/main/java/org/apache/iceberg/rest/RESTClientFactory.java: ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest; + +import java.util.Map; +import java.util.function.Function; + +public interface RESTClientFactory extends Function<Map<String, String>, RESTClient> { Review Comment: Originally, this had more recognizable benefit. I decided to keep it in so that the hierarchy of `REST*` being the interface and then `HTTP*` being the implementing class, like `RESTClient` <-> `HTTPClient`, would be kept. However, since this is a plain functional interface, I agree it doesn't provide much benefit. Will remove. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
