rajarshisarkar commented on code in PR #4489:
URL: https://github.com/apache/iceberg/pull/4489#discussion_r842382192
##########
dell/src/main/java/org/apache/iceberg/dell/ecs/EcsOutputFile.java:
##########
@@ -25,18 +25,24 @@
import org.apache.iceberg.io.InputFile;
import org.apache.iceberg.io.OutputFile;
import org.apache.iceberg.io.PositionOutputStream;
+import org.apache.iceberg.metrics.MetricsContext;
class EcsOutputFile extends BaseEcsFile implements OutputFile {
public static EcsOutputFile fromLocation(String location, S3Client client) {
- return new EcsOutputFile(client, new EcsURI(location), new
DellProperties());
+ return new EcsOutputFile(client, new EcsURI(location), new
DellProperties(), MetricsContext.nullMetrics());
}
public static EcsOutputFile fromLocation(String location, S3Client client,
DellProperties dellProperties) {
- return new EcsOutputFile(client, new EcsURI(location), dellProperties);
+ return new EcsOutputFile(client, new EcsURI(location), dellProperties,
MetricsContext.nullMetrics());
Review Comment:
Yes, that should be in-line with the other FileIO's. I have deprecated both
the public static methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
