YesOrNo828 commented on code in PR #4329: URL: https://github.com/apache/iceberg/pull/4329#discussion_r843430043
########## flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java: ########## @@ -75,7 +85,9 @@ private final boolean caseSensitive; private final boolean exposeLocality; private final Long snapshotId; + private final StreamingStartingStrategy startingStrategy; private final Long startSnapshotId; + private final Long startSnapshotTimestamp; Review Comment: Should we add the other Long parameter : `endSnapshotTimestamp`? just like `startSnapshotId` and `endSnapshotId`. ########## flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/StreamingStartingStrategy.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.flink.source; + +/** + * Starting strategy for streaming execution. Note that starting snapshot is exclusive in the incremental + * split discovery mode. Files appended by the starting snapshot aren't included in split discovery. + */ +public enum StreamingStartingStrategy { Review Comment: Is this just a strategy for unbounded reading ? And will there be a strategy for bounded reading, e.g. `BatchStartingStragegy` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
